Skip to content

Update wave jobs to use COMIN/COMOUT#2643

Merged
aerorahul merged 72 commits into
NOAA-EMC:developfrom
HenryRWinterbottom:feature/gwdev_issue_2451
Jun 26, 2024
Merged

Update wave jobs to use COMIN/COMOUT#2643
aerorahul merged 72 commits into
NOAA-EMC:developfrom
HenryRWinterbottom:feature/gwdev_issue_2451

Conversation

@HenryRWinterbottom
Copy link
Copy Markdown
Contributor

@HenryRWinterbottom HenryRWinterbottom commented May 30, 2024 •
edited
Loading

Description

NCO has requested that each COM variable specify whether it is an input or an output. This completes that process for the global-workflow wave model and products tasks.

Refs #2451

JJOB Script COMIN/COMOUT
JGLOBAL_WAVE_INIT exgfs_wave_init.sh ${COMOUT_WAVE_PREP}/${RUN}wave.mod_def.${grdID}
JGLOBAL_WAVE_INIT exgfs_wave_init.sh ${COMOUT_WAVE_PREP}/${RUN}wave.mod_def.${grdID}
JGLOBAL_WAVE_INIT exgfs_wave_init.sh ${COMOUT_WAVE_PREP_MEM}/${RUN}wave.mod_def.${grdID}
JGLOBAL_WAVE_POST_SBS exgfs_wave_post_gridded_sbs.sh ${COMIN_WAVE_PREP}/${RUN}wave.mod_def.${grdID}
JGLOBAL_WAVE_POST_SBS exgfs_wave_post_gridded_sbs.sh ${COMIN_WAVE_HISTORY}/${WAV_MOD_TAG}.out_grd.${wavGRD}.${YMD}.${HMS}
JGLOBAL_WAVE_POST_SBS exgfs_wave_post_gridded_sbs.sh ${COMIN_WAVE_GRID}/${gribchk}
JGLOBAL_WAVE_POST_SBS exgfs_wave_post_gridded_sbs.sh ${COMOUT_WAVE_GRID}/${outfile}.idx
JGLOBAL_WAVE_POST_SBS exgfs_wave_post_gridded_sbs.sh ${COMOUT_WAVE_PREP}/${WAV_MOD_TAG}.out_grd.${grdID}.${PDY}${cyc}
JGLOBAL_WAVE_POST_BNDPNT exgfs_wave_post_pnt.sh ${COMIN_WAVE_PREP}/${RUN}wave.mod_def.${grdID}
JGLOBAL_WAVE_POST_BNDPNT exgfs_wave_post_pnt.sh ${COMIN_WAVE_HISTORY}/${WAV_MOD_TAG}.out_pnt.${waveuoutpGRD}.${PDY}.${HMS}
JGLOBAL_WAVE_POST_BNDPNT exgfs_wave_post_pnt.sh ${COMOUT_WAVE_STATION}/${file_name}
JGLOBAL_WAVE_POST_BNDPNTBLL exgfs_wave_post_pnt.sh ${COMIN_WAVE_PREP}/${RUN}wave.mod_def.${grdID}
JGLOBAL_WAVE_POST_BNDPNTBLL exgfs_wave_post_pnt.sh ${COMIN_WAVE_HISTORY}/${WAV_MOD_TAG}.out_pnt.${waveuoutpGRD}.${PDY}.${HMS}
JGLOBAL_WAVE_POST_BNDPNTBLL exgfs_wave_post_pnt.sh ${COMOUT_WAVE_STATION}/${file_name}
JGLOBAL_WAVE_POST_PNT exgfs_wave_post_pnt.sh ${COMIN_WAVE_PREP}/${RUN}wave.mod_def.${grdID}
JGLOBAL_WAVE_POST_PNT exgfs_wave_post_pnt.sh ${COMIN_WAVE_HISTORY}/${WAV_MOD_TAG}.out_pnt.${waveuoutpGRD}.${PDY}.${HMS}
JGLOBAL_WAVE_POST_PNT exgfs_wave_post_pnt.sh ${COMOUT_WAVE_STATION}/${file_name}
JGLOBAL_WAVE_PRDGEN_BULLS exgfs_wave_prdgen_bulls.sh ${COMIN_WAVE_STATION}/${RUNwave}.${cycle}.cbull_tar
JGLOBAL_WAVE_PRDGEN_BULLS exgfs_wave_prdgen_bulls.sh ${COMOUT_WAVE_WMO}/awipsbull.${cycle}.${RUNwave}
JGLOBAL_WAVE_PRDGEN_BULLS exgfs_wave_prdgen_bulls.sh ${COMIN_WAVE_STATION}/${RUNwave}.${cycle}.cbull_tar
JGLOBAL_WAVE_PRDGEN_GRIDDED exgfs_wave_prdgen_gridded.sh ${COMIN_WAVE_GRID}/${RUNwave}.${cycle}.${grdID}.f${fhr}.grib2
JGLOBAL_WAVE_PRDGEN_GRIDDED exgfs_wave_prdgen_gridded.sh ${COMOUT_WAVE_WMO}/grib2.${cycle}.f${fhr}.awipsww3_${grdOut}
JGLOBAL_WAVE_PREP exgfs_wave_prep.sh ${COMIN_WAVE_PREP}/${RUN}wave.mod_def.${grdID}
JGLOBAL_WAVE_PREP exgfs_wave_prep.sh ${COMIN_RTOFS}/${WAVECUR_DID}.${RPDY}/rtofs_glo_2ds_f#HHH_prog.nc
JGLOBAL_WAVE_PREP exgfs_wave_prep.sh ${COMOUT_WAVE_PREP}/${RUN}wave.${WAVECUR_FID}.$cycle.cur

Type of change

  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

  • C48_S2SW experiment on RDHPCS Hera:
       CYCLE                    TASK                       JOBID               STATE         EXIT STATUS     TRIES      DURATION
================================================================================================================================
202103231200             gfsstage_ic                    61033738           SUCCEEDED                   0         1          25.0
202103231200             gfswaveinit                    61033739           SUCCEEDED                   0         1          33.0
202103231200                 gfsfcst                    61034011           SUCCEEDED                   0         1        2291.0
202103231200    gfsatmos_prod_f000-f006                    61034505           SUCCEEDED                   0         1         393.0
202103231200    gfsatmos_prod_f009-f015                    61034506           SUCCEEDED                   0         1         392.0
202103231200    gfsatmos_prod_f018-f024                    61034648           SUCCEEDED                   0         1         399.0
202103231200    gfsatmos_prod_f027-f033                    61034649           SUCCEEDED                   0         1         393.0
202103231200    gfsatmos_prod_f036-f042                    61035002           SUCCEEDED                   0         1         392.0
202103231200    gfsatmos_prod_f045-f051                    61034983           SUCCEEDED                   0         1         397.0
202103231200    gfsatmos_prod_f054-f060                    61035173           SUCCEEDED                   0         1         399.0
202103231200    gfsatmos_prod_f063-f069                    61035177           SUCCEEDED                   0         1         396.0
202103231200    gfsatmos_prod_f072-f078                    61035433           SUCCEEDED                   0         1         389.0
202103231200    gfsatmos_prod_f081-f087                    61035431           SUCCEEDED                   0         1         397.0
202103231200    gfsatmos_prod_f090-f096                    61035764           SUCCEEDED                   0         1         398.0
202103231200    gfsatmos_prod_f099-f105                    61035767           SUCCEEDED                   0         1         399.0
202103231200    gfsatmos_prod_f108-f114                    61036360           SUCCEEDED                   0         1         395.0
202103231200    gfsatmos_prod_f117-f120                    61036361           SUCCEEDED                   0         1         267.0
202103231200              gfstracker                    61037379           SUCCEEDED                   0         1          75.0
202103231200              gfsgenesis                    61037381           SUCCEEDED                   0         1         531.0
202103231200    gfsocean_prod_f006-f018                    61034711           SUCCEEDED                   0         1          80.0
202103231200    gfsocean_prod_f024-f036                    61035025           SUCCEEDED                   0         1          87.0
202103231200    gfsocean_prod_f042-f054                    61035204           SUCCEEDED                   0         1          81.0
202103231200    gfsocean_prod_f060-f072                    61035450           SUCCEEDED                   0         1          79.0
202103231200    gfsocean_prod_f078-f090                    61036206           SUCCEEDED                   0         1          89.0
202103231200    gfsocean_prod_f096-f108                    61036515           SUCCEEDED                   0         1          92.0
202103231200    gfsocean_prod_f114-f120                    61036519           SUCCEEDED                   0         1          62.0
202103231200    gfsice_prod_f006-f018                    61034507           SUCCEEDED                   0         1          65.0
202103231200    gfsice_prod_f024-f036                    61034712           SUCCEEDED                   0         1          61.0
202103231200    gfsice_prod_f042-f054                    61035026           SUCCEEDED                   0         1          66.0
202103231200    gfsice_prod_f060-f072                    61035451           SUCCEEDED                   0         1          61.0
202103231200    gfsice_prod_f078-f090                    61036207           SUCCEEDED                   0         1          71.0
202103231200    gfsice_prod_f096-f108                    61036520           SUCCEEDED                   0         1          66.0
202103231200    gfsice_prod_f114-f120                    61036521           SUCCEEDED                   0         1          42.0
202103231200          gfswavepostsbs                    61034184           SUCCEEDED                   0         1        2233.0
202103231200          gfswavepostpnt                    61036522           SUCCEEDED                   0         1       11192.0

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

@HenryRWinterbottom HenryRWinterbottom marked this pull request as ready for review May 30, 2024 23:09
WalterKolczynski-NOAA
WalterKolczynski-NOAA requested changes May 31, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@WalterKolczynski-NOAA WalterKolczynski-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not done yet, but things to get you started.

Comment thread jobs/JGLOBAL_WAVE_INIT Outdated
Comment thread jobs/JGLOBAL_WAVE_POST_BNDPNT Outdated
Comment thread jobs/JGLOBAL_WAVE_POST_BNDPNTBLL Outdated
Comment thread jobs/JGLOBAL_WAVE_POST_PNT Outdated
Comment thread jobs/JGLOBAL_WAVE_POST_SBS Outdated
Comment thread jobs/JGLOBAL_WAVE_PRDGEN_GRIDDED Outdated
Comment thread jobs/JGLOBAL_WAVE_PREP Outdated
Comment thread scripts/exgfs_wave_init.sh Outdated
Comment thread scripts/exgfs_wave_init.sh Outdated
Comment thread jobs/JGLOBAL_WAVE_INIT Outdated
HenryRWinterbottom and others added 14 commits May 31, 2024 08:46
@HenryRWinterbottom @WalterKolczynski-NOAA
Update jobs/JGLOBAL_WAVE_INIT
3118937 
Addressing reviewer comment.

Co-authored-by: Walter Kolczynski - NOAA <Walter.Kolczynski@noaa.gov>
@HenryRWinterbottom @WalterKolczynski-NOAA
Update jobs/JGLOBAL_WAVE_POST_BNDPNT
31082aa 
Addressing reviewer comment.

Co-authored-by: Walter Kolczynski - NOAA <Walter.Kolczynski@noaa.gov>
@HenryRWinterbottom @WalterKolczynski-NOAA
Update jobs/JGLOBAL_WAVE_POST_BNDPNTBLL
a9a0258 
Addressing reviewer suggestion.

Co-authored-by: Walter Kolczynski - NOAA <Walter.Kolczynski@noaa.gov>
@HenryRWinterbottom @WalterKolczynski-NOAA
Update jobs/JGLOBAL_WAVE_POST_PNT
94a9688 
Addressing reviewer suggestion.

Co-authored-by: Walter Kolczynski - NOAA <Walter.Kolczynski@noaa.gov>
@HenryRWinterbottom @WalterKolczynski-NOAA
Update jobs/JGLOBAL_WAVE_POST_SBS
cdb0e82 
Addressing reviewer suggestion.

Co-authored-by: Walter Kolczynski - NOAA <Walter.Kolczynski@noaa.gov>
@HenryRWinterbottom @WalterKolczynski-NOAA
Update jobs/JGLOBAL_WAVE_POST_SBS
883fa7c 
Addressing reviewer suggestion.

Co-authored-by: Walter Kolczynski - NOAA <Walter.Kolczynski@noaa.gov>
@HenryRWinterbottom @WalterKolczynski-NOAA
Update jobs/JGLOBAL_WAVE_PRDGEN_BULLS
2a81ae8 
Addressing reviewer suggestion.

Co-authored-by: Walter Kolczynski - NOAA <Walter.Kolczynski@noaa.gov>
@HenryRWinterbottom @WalterKolczynski-NOAA
Update jobs/JGLOBAL_WAVE_PRDGEN_GRIDDED
87e2492 
Addressing reviewer suggestion.

Co-authored-by: Walter Kolczynski - NOAA <Walter.Kolczynski@noaa.gov>
@HenryRWinterbottom @WalterKolczynski-NOAA
Update jobs/JGLOBAL_WAVE_PREP
4d27a6c 
Addressing reviewer suggestion.

Co-authored-by: Walter Kolczynski - NOAA <Walter.Kolczynski@noaa.gov>
@HenryRWinterbottom @WalterKolczynski-NOAA
Update jobs/JGLOBAL_WAVE_PRDGEN_GRIDDED
cb1764c 
global-workflow.gwdev_issue_2444.r002.ci

Co-authored-by: Walter Kolczynski - NOAA <Walter.Kolczynski@noaa.gov>
@HenryRWinterbottom @WalterKolczynski-NOAA
Update scripts/exgfs_wave_init.sh
1241ede 
global-workflow.gwdev_issue_2444.r002.ci

Co-authored-by: Walter Kolczynski - NOAA <Walter.Kolczynski@noaa.gov>
@HenryRWinterbottom @WalterKolczynski-NOAA
Update jobs/JGLOBAL_WAVE_INIT
b0c7bad 
Addressing reviewer comment.

Co-authored-by: Walter Kolczynski - NOAA <Walter.Kolczynski@noaa.gov>
@HenryRWinterbottom
Addressing reviewer suggestion.
4b2f7ce
@HenryRWinterbottom
Merge branch 'develop' into feature/gwdev_issue_2451
8f65499
WalterKolczynski-NOAA
WalterKolczynski-NOAA requested changes Jun 4, 2024
View reviewed changes
Comment thread ush/wave_tar.sh Outdated
Comment thread ush/wave_prnc_ice.sh Outdated
Comment thread ush/wave_grid_interp_sbs.sh Outdated
Comment thread ush/wave_grid_interp_sbs.sh Outdated
Comment thread jobs/JGLOBAL_WAVE_POST_SBS
Comment thread jobs/JGLOBAL_WAVE_POST_BNDPNT Outdated
Comment thread jobs/JGLOBAL_WAVE_POST_BNDPNT Outdated
Comment thread jobs/JGLOBAL_WAVE_POST_PNT Outdated
Comment thread jobs/JGLOBAL_WAVE_POST_SBS Outdated
Comment thread jobs/JGLOBAL_WAVE_INIT Outdated
HenryRWinterbottom and others added 2 commits June 4, 2024 08:28
@HenryRWinterbottom @WalterKolczynski-NOAA
Update ush/wave_tar.sh
cc4b281 
Addressing reviewer comment(s).

Co-authored-by: Walter Kolczynski - NOAA <Walter.Kolczynski@noaa.gov>
@HenryRWinterbottom @WalterKolczynski-NOAA
Update ush/wave_prnc_ice.sh
d17d688 
Addressing reviewer comment(s).

Co-authored-by: Walter Kolczynski - NOAA <Walter.Kolczynski@noaa.gov>
@emcbot emcbot removed the CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress label Jun 25, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented Jun 25, 2024

CI Passed Hercules at
Built and ran in directory /work2/noaa/stmp/CI/HERCULES/2643

@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Wcoss2-Ready PR is ready for CI testing on WCOSS2. label Jun 25, 2024
@emcbot emcbot added CI-Wcoss2-Building CI testing is cloning/building on WCOSS2 and removed CI-Wcoss2-Ready PR is ready for CI testing on WCOSS2. labels Jun 25, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented Jun 25, 2024 

CI Update on Wcoss2 at 06/25/24 07:06:12 PM
============================================
Cloning and Building global-workflow PR: 2643
with PID: 111671 on host: dlogin08

@emcbot emcbot added CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress and removed CI-Wcoss2-Building CI testing is cloning/building on WCOSS2 labels Jun 25, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented Jun 25, 2024

Automated global-workflow Testing Results:

Machine: Wcoss2
Start: Tue Jun 25 19:10:31 UTC 2024 on dlogin08
---------------------------------------------------
Build: Completed at 06/25/24 07:46:03 PM
Case setup: Completed for experiment C48_ATM_e17eec77
Case setup: Skipped for experiment C48mx500_3DVarAOWCDA_e17eec77
Case setup: Skipped for experiment C48_S2SWA_gefs_e17eec77
Case setup: Completed for experiment C48_S2SW_e17eec77
Case setup: Completed for experiment C96_atm3DVar_extended_e17eec77
Case setup: Skipped for experiment C96_atm3DVar_e17eec77
Case setup: Skipped for experiment C96_atmaerosnowDA_e17eec77
Case setup: Completed for experiment C96C48_hybatmDA_e17eec77
Case setup: Completed for experiment C96C48_ufs_hybatmDA_e17eec77

@emcbot
Copy link
Copy Markdown

emcbot commented Jun 25, 2024

Experiment C48_ATM_e17eec77 SUCCESS on Wcoss2 at 06/25/24 09:08:16 PM

@emcbot
Copy link
Copy Markdown

emcbot commented Jun 25, 2024

Experiment C48_S2SW_e17eec77 SUCCESS on Wcoss2 at 06/25/24 09:12:09 PM

@emcbot
Copy link
Copy Markdown

emcbot commented Jun 25, 2024

Experiment C96C48_hybatmDA_e17eec77 SUCCESS on Wcoss2 at 06/25/24 10:32:22 PM

@emcbot
Copy link
Copy Markdown

emcbot commented Jun 25, 2024

Experiment C96C48_ufs_hybatmDA_e17eec77 SUCCESS on Wcoss2 at 06/25/24 10:32:26 PM

@emcbot
Copy link
Copy Markdown

emcbot commented Jun 26, 2024

Experiment C96_atm3DVar_extended_e17eec77 SUCCESS on Wcoss2 at 06/26/24 06:36:27 AM

@emcbot emcbot added CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully and removed CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress labels Jun 26, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented Jun 26, 2024

All CI Test Cases Passed on Wcoss2:

Experiment C48_ATM_e17eec77 *** SUCCESS *** at 06/25/24 09:08:16 PM
Experiment C48_S2SW_e17eec77 *** SUCCESS *** at 06/25/24 09:12:09 PM
Experiment C96C48_hybatmDA_e17eec77 *** SUCCESS *** at 06/25/24 10:32:22 PM
Experiment C96C48_ufs_hybatmDA_e17eec77 *** SUCCESS *** at 06/25/24 10:32:26 PM
Experiment C96_atm3DVar_extended_e17eec77 *** SUCCESS *** at 06/26/24 06:36:27 AM

@aerorahul aerorahul merged commit 12431f7 into NOAA-EMC:develop Jun 26, 2024
@HenryRWinterbottom HenryRWinterbottom deleted the feature/gwdev_issue_2451 branch June 27, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aerorahul aerorahul aerorahul approved these changes

@JessicaMeixner-NOAA JessicaMeixner-NOAA JessicaMeixner-NOAA approved these changes

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

@KateFriedman-NOAA KateFriedman-NOAA Awaiting requested review from KateFriedman-NOAA

Assignees

No one assigned

Labels

CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@HenryRWinterbottom @emcbot @aerorahul @WalterKolczynski-NOAA @JessicaMeixner-NOAA @KateFriedman-NOAA @github-advanced-security @henrywinterbottom-wxdev